Commit messages from review rework.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Commit messages from review rework.

Luke Daley-2
Hi,

I think we can do better with commit messages for review rework. I don’t think there’s a point in explicitly stating that the changes are in response to review, rather we should follow the normal practice of trying to succinctly describe the change or the rationale for the change.

The existence of the review key should imply enough about the correlation with the review.


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Commit messages from review rework.

Gary Hale
Point taken.  I agree it doesn't add anything and makes the one line history less descriptive.  Thanks for pointing it out.

Gary


On Sun, Aug 10, 2014 at 9:03 PM, Luke Daley <[hidden email]> wrote:
Hi,

I think we can do better with commit messages for review rework. I don’t think there’s a point in explicitly stating that the changes are in response to review, rather we should follow the normal practice of trying to succinctly describe the change or the rationale for the change.

The existence of the review key should imply enough about the correlation with the review.



Loading...