Feedback on commits

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Feedback on commits

hans_d
Administrator
Hi Adam,

it's great to see how you improve the consistency in the code base.

I have one question regarding your last commits. Does it make sense  
to set the default values for the build and settings file in the  
StartParameter class? We do set already the default values in the  
Main class. Now we have two places where we do this, which might make  
things harder to understand. For example changing the default names  
in the StartParameter class would not have any effect right now.

- Hans

--
Hans Dockter
Gradle Project lead
http://www.gradle.org





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

Re: Feedback on commits

Adam Murdoch-2


Hans Dockter wrote:
> I have one question regarding your last commits. Does it make sense to
> set the default values for the build and settings file in the
> StartParameter class?
No, not really :)

I was playing around with moving some of the defaults around, mainly so
that they're somewhere that is reusable when  embedding gradle, other
than the static main() method. My eventual goal is to end up with an
embedding api and a gradle invocation api (ie equivalents to the <ant>
task).

Regardless, I rolled back what I had done and missed the change to
StartParameter. I'll fix it up soon.


Adam


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email