User Guide: docs build doesn't update if PNG file changes

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

User Guide: docs build doesn't update if PNG file changes

KARR, DAVID
I noticed that the user guide build doesn't properly update if any of the associated PNG files are changed.  I was able to get it to work by first "clean"ing, but I would think it should have dealt with this properly.  Is this perhaps a bug in the "Docbook2Xhtml" task, or the use of it?

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

Re: User Guide: docs build doesn't update if PNG file changes

Luke Daley-2


On 8 July 2014 at 8:14:15 am, KARR, DAVID ([hidden email]) wrote:

I noticed that the user guide build doesn't properly update if any of the associated PNG files are changed. I was able to get it to work by first "clean"ing, but I would think it should have dealt with this properly. Is this perhaps a bug in the "Docbook2Xhtml" task, or the use of it?

This shouldn’t be the case:

https://github.com/gradle/gradle/blob/master/subprojects/docs/docs.gradle#L279-279

https://github.com/gradle/gradle/blob/master/buildSrc/src/main/groovy/org/gradle/build/docs/Docbook2Xhtml.groovy#L41-41


Can you list the exact steps you took please.


— 

Luke Daley
http://www.gradleware.com
Reply | Threaded
Open this post in threaded view
|

RE: User Guide: docs build doesn't update if PNG file changes

KARR, DAVID

 

 

From: Luke Daley [mailto:[hidden email]]
Sent: Monday, July 07, 2014 5:13 PM
To: [hidden email]
Subject: Re: [gradle-dev] User Guide: docs build doesn't update if PNG file changes

 

 

 

On 8 July 2014 at 8:14:15 am, KARR, DAVID ([hidden email]) wrote:

I noticed that the user guide build doesn't properly update if any of the associated PNG files are changed. I was able to get it to work by first "clean"ing, but I would think it should have dealt with this properly. Is this perhaps a bug in the "Docbook2Xhtml" task, or the use of it?

This shouldn’t be the case:

https://github.com/gradle/gradle/blob/master/subprojects/docs/docs.gradle#L279-279

https://github.com/gradle/gradle/blob/master/buildSrc/src/main/groovy/org/gradle/build/docs/Docbook2Xhtml.groovy#L41-41

 

Can you list the exact steps you took please.

I edited the .graphml file.  I exported the png to the same directory, overwriting the existing file.  Then, in the “gradle” directory, I ran “gradle docs:userguide”.  I then viewed the result, and it was the old version.  Just in case, I ran this build again, with the same result.  I then did “gradle docs:clean”, then “gradle docs:userguide” and inspected the result, and it was using the new version.

— 

 

Luke Daley

Reply | Threaded
Open this post in threaded view
|

Re: User Guide: docs build doesn't update if PNG file changes

Daz DeBoer-2
On Mon, Jul 7, 2014 at 6:48 PM, KARR, DAVID <[hidden email]> wrote:

 

 

From: Luke Daley [mailto:[hidden email]]
Sent: Monday, July 07, 2014 5:13 PM
To: [hidden email]
Subject: Re: [gradle-dev] User Guide: docs build doesn't update if PNG file changes

 

 

 

On 8 July 2014 at 8:14:15 am, KARR, DAVID ([hidden email]) wrote:

I noticed that the user guide build doesn't properly update if any of the associated PNG files are changed. I was able to get it to work by first "clean"ing, but I would think it should have dealt with this properly. Is this perhaps a bug in the "Docbook2Xhtml" task, or the use of it?

This shouldn’t be the case:

https://github.com/gradle/gradle/blob/master/subprojects/docs/docs.gradle#L279-279

https://github.com/gradle/gradle/blob/master/buildSrc/src/main/groovy/org/gradle/build/docs/Docbook2Xhtml.groovy#L41-41

 

Can you list the exact steps you took please.

I edited the .graphml file.  I exported the png to the same directory, overwriting the existing file.  Then, in the “gradle” directory, I ran “gradle docs:userguide”.  I then viewed the result, and it was the old version.  Just in case, I ran this build again, with the same result.  I then did “gradle docs:clean”, then “gradle docs:userguide” and inspected the result, and it was using the new version.



In the past I've noticed that I occasionally need to 'clean' in order to get the fresh docs generated. There's likely some bug in our up-to-date logic for generating docs. I've never taken the time to track this down properly, but it would be good to fix. 

--
Darrell (Daz) DeBoer
Reply | Threaded
Open this post in threaded view
|

Re: User Guide: docs build doesn't update if PNG file changes

Rene Groeschke
Hey,
I looked into it and the incremental build of the userguide pdf was broken (the html userguides worked) as it just takes an html as an input but didn't took the referenced pngs into account when checking up-to-date. This should be fixed now in master. Thanks David for pointing that out.

cheers,
René



8 Jul 2014 04:52

 

 

From: Luke Daley [mailto:[hidden email]]
Sent: Monday, July 07, 2014 5:13 PM
To: [hidden email]
Subject: Re: [gradle-dev] User Guide: docs build doesn't update if PNG file changes

I edited the .graphml file.  I exported the png to the same directory, overwriting the existing file.  Then, in the “gradle” directory, I ran “gradle docs:userguide”.  I then viewed the result, and it was the old version.  Just in case, I ran this build again, with the same result.  I then did “gradle docs:clean”, then “gradle docs:userguide” and inspected the result, and it was using the new version.



In the past I've noticed that I occasionally need to 'clean' in order to get the fresh docs generated. There's likely some bug in our up-to-date logic for generating docs. I've never taken the time to track this down properly, but it would be good to fix. 

--
Darrell (Daz) DeBoer
8 Jul 2014 02:48

 

 

From: Luke Daley [[hidden email]]
Sent: Monday, July 07, 2014 5:13 PM
To: [hidden email]
Subject: Re: [gradle-dev] User Guide: docs build doesn't update if PNG file changes

 

 

 

On 8 July 2014 at 8:14:15 am, KARR, DAVID ([hidden email]) wrote:

This shouldn’t be the case:

https://github.com/gradle/gradle/blob/master/subprojects/docs/docs.gradle#L279-279

https://github.com/gradle/gradle/blob/master/buildSrc/src/main/groovy/org/gradle/build/docs/Docbook2Xhtml.groovy#L41-41

 

Can you list the exact steps you took please.

I edited the .graphml file.  I exported the png to the same directory, overwriting the existing file.  Then, in the “gradle” directory, I ran “gradle docs:userguide”.  I then viewed the result, and it was the old version.  Just in case, I ran this build again, with the same result.  I then did “gradle docs:clean”, then “gradle docs:userguide” and inspected the result, and it was using the new version.

— 

 

Luke Daley

8 Jul 2014 02:13
8 Jul 2014 00:13
I noticed that the user guide build doesn't properly update if any of the associated PNG files are changed. I was able to get it to work by first "clean"ing, but I would think it should have dealt with this properly. Is this perhaps a bug in the "Docbook2Xhtml" task, or the use of it?

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email