Windows locking issue

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Windows locking issue

Guillaume Laforge
Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

Reply | Threaded
Open this post in threaded view
|

Re: Windows locking issue

Luke Daley-2
It’s too late to get this fixed in 2.0, but I’ll take a look when I’m back next week and see if we can get it fixed for 2.1.

On 15 June 2014 at 10:29:01 pm, Guillaume Laforge ([hidden email]) wrote:

Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: http://www.gradlesummit.com
Reply | Threaded
Open this post in threaded view
|

Re: Windows locking issue

Guillaume Laforge
Thanks Luke!


On Fri, Jun 20, 2014 at 1:58 AM, Luke Daley <[hidden email]> wrote:
It’s too late to get this fixed in 2.0, but I’ll take a look when I’m back next week and see if we can get it fixed for 2.1.

On 15 June 2014 at 10:29:01 pm, Guillaume Laforge ([hidden email]) wrote:

Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: http://www.gradlesummit.com



--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

Reply | Threaded
Open this post in threaded view
|

Re: Windows locking issue

Luke Daley-2
Hi Guillaume,

This basically boils down to a bug in the asciidoctor plugin and a terse error message on Gradle’s part. Please see Gary’s comment here: http://issues.gradle.org/browse/GRADLE-2967?focusedCommentId=18916&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18916.

On 20 June 2014 at 5:52:25 pm, Guillaume Laforge ([hidden email]) wrote:

Thanks Luke!


On Fri, Jun 20, 2014 at 1:58 AM, Luke Daley <[hidden email]> wrote:
It’s too late to get this fixed in 2.0, but I’ll take a look when I’m back next week and see if we can get it fixed for 2.1.

On 15 June 2014 at 10:29:01 pm, Guillaume Laforge ([hidden email]) wrote:

Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: http://www.gradlesummit.com



--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Reply | Threaded
Open this post in threaded view
|

Re: Windows locking issue

Guillaume Laforge
Thanks Luke!
I'll point Dan and Andrés to this comment.


On Fri, Jun 27, 2014 at 1:50 AM, Luke Daley <[hidden email]> wrote:
Hi Guillaume,

This basically boils down to a bug in the asciidoctor plugin and a terse error message on Gradle’s part. Please see Gary’s comment here: http://issues.gradle.org/browse/GRADLE-2967?focusedCommentId=18916&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18916.

On 20 June 2014 at 5:52:25 pm, Guillaume Laforge ([hidden email]) wrote:

Thanks Luke!


On Fri, Jun 20, 2014 at 1:58 AM, Luke Daley <[hidden email]> wrote:
It’s too late to get this fixed in 2.0, but I’ll take a look when I’m back next week and see if we can get it fixed for 2.1.

On 15 June 2014 at 10:29:01 pm, Guillaume Laforge ([hidden email]) wrote:

Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: http://www.gradlesummit.com



--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware



--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

Reply | Threaded
Open this post in threaded view
|

Re: Windows locking issue

Gary Hale
In reply to this post by Guillaume Laforge

I've made a simple change to capture the file name in the exception when hashing fails so this at least provides a minimum of information when this sort of thing occurs, but it's pretty basic and doesn't really provide information about the context in which the error occurs.  

I think part of the problem with this issue was that on the surface it appeared like an error while accessing the cache when in fact it was an error while hashing the inputs.  Snapshotting is not the only place where hashing is used - I wonder if it would make sense to put some effort into catching hash-related IO exceptions somewhere as they bubble up and provide some information about the context?  Thoughts?

Gary


Hi Guillaume,

This basically boils down to a bug in the asciidoctor plugin and a terse error message on Gradle’s part. Please see Gary’s comment here: http://issues.gradle.org/browse/GRADLE-2967?focusedCommentId=18916&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18916.

On 20 June 2014 at 5:52:25 pm, Guillaume Laforge ([hidden email]) wrote:

Thanks Luke!


On Fri, Jun 20, 2014 at 1:58 AM, Luke Daley <[hidden email]> wrote:
It’s too late to get this fixed in 2.0, but I’ll take a look when I’m back next week and see if we can get it fixed for 2.1.

On 15 June 2014 at 10:29:01 pm, Guillaume Laforge ([hidden email]) wrote:

Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: http://www.gradlesummit.com



--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware



Reply | Threaded
Open this post in threaded view
|

Re: Windows locking issue

Luke Daley-2


On 28 June 2014 at 1:55:24 am, Gary Hale ([hidden email]) wrote:


I've made a simple change to capture the file name in the exception when hashing fails so this at least provides a minimum of information when this sort of thing occurs, but it's pretty basic and doesn't really provide information about the context in which the error occurs.  

I think part of the problem with this issue was that on the surface it appeared like an error while accessing the cache when in fact it was an error while hashing the inputs.  Snapshotting is not the only place where hashing is used - I wonder if it would make sense to put some effort into catching hash-related IO exceptions somewhere as they bubble up and provide some information about the context?  Thoughts?

I think we need two things:

1. The name of the file that we fail to hash in that exception message

2. An exception that wraps exception that occur when snapshotting that indicates the task, and the property of the task that declares the files to be snapshotted




Gary


Hi Guillaume,

This basically boils down to a bug in the asciidoctor plugin and a terse error message on Gradle’s part. Please see Gary’s comment here: http://issues.gradle.org/browse/GRADLE-2967?focusedCommentId=18916&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18916.

On 20 June 2014 at 5:52:25 pm, Guillaume Laforge ([hidden email]) wrote:

Thanks Luke!


On Fri, Jun 20, 2014 at 1:58 AM, Luke Daley <[hidden email]> wrote:
It’s too late to get this fixed in 2.0, but I’ll take a look when I’m back next week and see if we can get it fixed for 2.1.

On 15 June 2014 at 10:29:01 pm, Guillaume Laforge ([hidden email]) wrote:

Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: http://www.gradlesummit.com



--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware




— 

Luke Daley
http://www.gradleware.com
Reply | Threaded
Open this post in threaded view
|

Re: Windows locking issue

Gary Hale

I think we need two things:

1. The name of the file that we fail to hash in that exception message

2. An exception that wraps exception that occur when snapshotting that indicates the task, and the property of the task that declares the files to be snapshotted

As far as #2 is concerned, getting the property of the task that declares the input might be pretty involved.  Problem is, once the inputs are added, they just get aggregated together and there is no post facto way to map resolved file to input property.  I think I see a way to achieve that, but it would require more than a little refactoring of the inputs/outputs handling.  I guess I'm wondering whether the effort/value balance is there for this specific case.  Maybe the right question is whether having a full lifecycle mapping of input file to input property (and vice versa) would be valuable in other scenarios?




Gary


Hi Guillaume,

This basically boils down to a bug in the asciidoctor plugin and a terse error message on Gradle’s part. Please see Gary’s comment here: http://issues.gradle.org/browse/GRADLE-2967?focusedCommentId=18916&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18916.

On 20 June 2014 at 5:52:25 pm, Guillaume Laforge ([hidden email]) wrote:

Thanks Luke!


On Fri, Jun 20, 2014 at 1:58 AM, Luke Daley <[hidden email]> wrote:
It’s too late to get this fixed in 2.0, but I’ll take a look when I’m back next week and see if we can get it fixed for 2.1.

On 15 June 2014 at 10:29:01 pm, Guillaume Laforge ([hidden email]) wrote:

Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: http://www.gradlesummit.com



--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware




— 

Luke Daley

Reply | Threaded
Open this post in threaded view
|

Re: Windows locking issue

Luke Daley-2


On 1 July 2014 at 9:07:02 am, Gary Hale ([hidden email]) wrote:


I think we need two things:

1. The name of the file that we fail to hash in that exception message

2. An exception that wraps exception that occur when snapshotting that indicates the task, and the property of the task that declares the files to be snapshotted

As far as #2 is concerned, getting the property of the task that declares the input might be pretty involved.  Problem is, once the inputs are added, they just get aggregated together and there is no post facto way to map resolved file to input property.  I think I see a way to achieve that, but it would require more than a little refactoring of the inputs/outputs handling.  I guess I'm wondering whether the effort/value balance is there for this specific case.  Maybe the right question is whether having a full lifecycle mapping of input file to input property (and vice versa) would be valuable in other scenarios?

Given this, let’s drop identifying the property. Just knowing which task and that it was determining up to date status would still be helpful.






Gary


Hi Guillaume,

This basically boils down to a bug in the asciidoctor plugin and a terse error message on Gradle’s part. Please see Gary’s comment here: http://issues.gradle.org/browse/GRADLE-2967?focusedCommentId=18916&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18916.

On 20 June 2014 at 5:52:25 pm, Guillaume Laforge ([hidden email]) wrote:

Thanks Luke!


On Fri, Jun 20, 2014 at 1:58 AM, Luke Daley <[hidden email]> wrote:
It’s too late to get this fixed in 2.0, but I’ll take a look when I’m back next week and see if we can get it fixed for 2.1.

On 15 June 2014 at 10:29:01 pm, Guillaume Laforge ([hidden email]) wrote:

Hi guys,

The Groovy project is affected by this Gradle issue here:

It affects users only on Windows (a file locking issue), with the Asciidoctor plugin, but as well with other plugins as users reported.

For us (Groovy project), it prevents building the documentation of Groovy on a Windows machine.

I'd be happy to see our Gradle experts investigate that issue, and find a workaround for this Windows specific problem.

Thanks for your attention.


--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware
Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: http://www.gradlesummit.com



--
Guillaume Laforge
Groovy Project Manager
Pivotal, Inc.

— 

Luke Daley
Gradleware






— 

Luke Daley
http://www.gradleware.com