regression in ivy resolution

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

regression in ivy resolution

Szczepan Faber
Hey,

I found this regression with 2.0: http://issues.gradle.org/browse/GRADLE-3141

@Adam, do you remember if this is the same we fixed in one of the
2.0-rc? I vaguely remember a problem like this before.

Cheers!
--
Szczepan Faber
Core dev@gradle; Founder@mockito

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

Re: regression in ivy resolution

Adam Murdoch

On 31 Jul 2014, at 8:00 am, Szczepan Faber <[hidden email]> wrote:

Hey,

I found this regression with 2.0: http://issues.gradle.org/browse/GRADLE-3141

@Adam, do you remember if this is the same we fixed in one of the
2.0-rc? I vaguely remember a problem like this before.

I think it’s a new problem. It just is triggered in the same way as some older issues.


Cheers!
--
Szczepan Faber
Core dev@gradle; Founder@mockito

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email




--
Adam Murdoch
Gradle Co-founder
http://www.gradle.org
CTO Gradleware Inc. - Gradle Training, Support, Consulting
http://www.gradleware.com



Reply | Threaded
Open this post in threaded view
|

Re: regression in ivy resolution

Szczepan Faber
Ok, thanks.

Do you want me to look into it? I can probably find some time for it
sometime not long from now.

Cheers!

On Thu, Jul 31, 2014 at 3:38 AM, Adam Murdoch
<[hidden email]> wrote:

>
> On 31 Jul 2014, at 8:00 am, Szczepan Faber <[hidden email]> wrote:
>
> Hey,
>
> I found this regression with 2.0:
> http://issues.gradle.org/browse/GRADLE-3141
>
> @Adam, do you remember if this is the same we fixed in one of the
> 2.0-rc? I vaguely remember a problem like this before.
>
>
> I think it's a new problem. It just is triggered in the same way as some
> older issues.
>
>
> Cheers!
> --
> Szczepan Faber
> Core dev@gradle; Founder@mockito
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>
>
> --
> Adam Murdoch
> Gradle Co-founder
> http://www.gradle.org
> CTO Gradleware Inc. - Gradle Training, Support, Consulting
> http://www.gradleware.com
>
>
>



--
Szczepan Faber
Core dev@gradle; Founder@mockito

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

Re: regression in ivy resolution

Adam Murdoch

On 31 Jul 2014, at 5:39 pm, Szczepan Faber <[hidden email]> wrote:

Ok, thanks.

Do you want me to look into it? I can probably find some time for it
sometime not long from now.

Yes, thanks.


Cheers!

On Thu, Jul 31, 2014 at 3:38 AM, Adam Murdoch
<[hidden email]> wrote:

On 31 Jul 2014, at 8:00 am, Szczepan Faber <[hidden email]> wrote:

Hey,

I found this regression with 2.0:
http://issues.gradle.org/browse/GRADLE-3141

@Adam, do you remember if this is the same we fixed in one of the
2.0-rc? I vaguely remember a problem like this before.


I think it's a new problem. It just is triggered in the same way as some
older issues.


Cheers!
--
Szczepan Faber
Core dev@gradle; Founder@mockito

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

  http://xircles.codehaus.org/manage_email




--
Adam Murdoch
Gradle Co-founder
http://www.gradle.org
CTO Gradleware Inc. - Gradle Training, Support, Consulting
http://www.gradleware.com






--
Szczepan Faber
Core dev@gradle; Founder@mockito

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email




--
Adam Murdoch
Gradle Co-founder
http://www.gradle.org
CTO Gradleware Inc. - Gradle Training, Support, Consulting
http://www.gradleware.com



Reply | Threaded
Open this post in threaded view
|

Re: regression in ivy resolution

Szczepan Faber
While working on this I found a bug in ivy. Artifact.equals() method
is not reliable. All because of a missing bracket after ternary
operator at http://grepcode.com/file/repository.springsource.com/org.apache.ant/com.springsource.org.apache.ivy/2.1.0/org/apache/ivy/core/module/descriptor/AbstractArtifact.java#35
Basically, if artifact has null publication date and the same module
identifier (ModuleRevisionId) as b, then a.equals(b) regardless of
artifact name, extension, type, etc.

I wonder how it worked so long without problems. And I'm totally
amazed with our test suite for core-impl that it caught this bug
(after I made changes to fix original issue).

Cheers!

On Thu, Jul 31, 2014 at 10:39 AM, Adam Murdoch
<[hidden email]> wrote:

>
> On 31 Jul 2014, at 5:39 pm, Szczepan Faber <[hidden email]> wrote:
>
> Ok, thanks.
>
> Do you want me to look into it? I can probably find some time for it
> sometime not long from now.
>
>
> Yes, thanks.
>
>
> Cheers!
>
> On Thu, Jul 31, 2014 at 3:38 AM, Adam Murdoch
> <[hidden email]> wrote:
>
>
> On 31 Jul 2014, at 8:00 am, Szczepan Faber <[hidden email]> wrote:
>
> Hey,
>
> I found this regression with 2.0:
> http://issues.gradle.org/browse/GRADLE-3141
>
> @Adam, do you remember if this is the same we fixed in one of the
> 2.0-rc? I vaguely remember a problem like this before.
>
>
> I think it's a new problem. It just is triggered in the same way as some
> older issues.
>
>
> Cheers!
> --
> Szczepan Faber
> Core dev@gradle; Founder@mockito
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>   http://xircles.codehaus.org/manage_email
>
>
>
>
> --
> Adam Murdoch
> Gradle Co-founder
> http://www.gradle.org
> CTO Gradleware Inc. - Gradle Training, Support, Consulting
> http://www.gradleware.com
>
>
>
>
>
>
> --
> Szczepan Faber
> Core dev@gradle; Founder@mockito
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>
>
> --
> Adam Murdoch
> Gradle Co-founder
> http://www.gradle.org
> CTO Gradleware Inc. - Gradle Training, Support, Consulting
> http://www.gradleware.com
>
>
>



--
Szczepan Faber
Core dev@gradle; Founder@mockito

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email